Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 12 #441

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Use Node 12 #441

merged 2 commits into from
Apr 13, 2021

Conversation

rekmarks
Copy link
Member

We're bumping to Node 12 all over the place due to Node 10 reaching EOL, and this should be no exception.

@rekmarks rekmarks requested a review from a team as a code owner April 13, 2021 15:46
@Gudahtt
Copy link
Member

Gudahtt commented Apr 13, 2021

Maybe worth adding an engines field as well? We've done so everywhere else

@rekmarks
Copy link
Member Author

Ah, done!

Gudahtt
Gudahtt approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit c575bb3 into develop Apr 13, 2021
@rekmarks rekmarks deleted the bump-node-version branch April 13, 2021 16:17
Gudahtt added a commit that referenced this pull request Apr 15, 2021
@Gudahtt
v8.0.0
25fdd00 
- Add restricted controller messenger ([#378](#378))

- **BREAKING:** Update minimum Node.js version to v12 ([#441](#441))
- **BREAKING:** Replace controller context ([#387](#387))
- Bump @metamask/contract-metadata from 1.23.0 to 1.24.0 ([#440](#440))
- Update lint rules ([#442](#442), [#426](#426))

- Don't remove collectibles during auto detection ([#439](#439))
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@rekmarks @MajorLift
Use Node 12 (#441)
01a5506 
* Use Node 12

* Add engines field
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@rekmarks @MajorLift
Use Node 12 (#441)
735a7f4 
* Use Node 12

* Add engines field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt