Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OpenSea Collection Name #628

Merged
merged 16 commits into from
Nov 25, 2021
Merged

[FIX] OpenSea Collection Name #628

merged 16 commits into from
Nov 25, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 5, 2021

Description

Currently the app has a bug that shows a collection name as Unidentified Contract. According to an OpenSea developer, the CollectiblesControllers should be using the property from collectible.name instead of name.

The issue appears to be with OpenSea's API. MetaMask calls /api/v1/asset_contract/0x1234... to fetch data about the contract, and for some contracts, the name parameter is returning "Unidentified Contract".
For example, see Curio Cards here- name is unidentified, but collection->name displays correctly. Perhaps metamask can work around this by accessing collection->name instead of name?

Tasks

  • Access collectible.name instead of name.
  • Update collectibles related objects (CollectibleMetadata and ApiCollectible)
  • Update ERC-1155 module
  • Update tests

References

hellbill
hellbill previously approved these changes Nov 9, 2021
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 3497fa8 into main Nov 25, 2021
@gantunesr gantunesr deleted the fix/opensea-collection-name branch November 25, 2021 02:25
@adonesky1 adonesky1 mentioned this pull request Nov 30, 2021
Copy link

@hellbill hellbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants