Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Minor NFTs bugs #3387

Merged
merged 27 commits into from
Dec 3, 2021
Merged

[FIX] Minor NFTs bugs #3387

merged 27 commits into from
Dec 3, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Nov 8, 2021 •
edited
Loading

⚠️ Blockers

Description

This development is destined to fix:

  • The lack of collection name on ERC-1155 NFTs in custom networks.
  • Add new attribute row indicating the NFT standard
  • The "Unidentified contract" bug by accessing a different attribute in the OpenSea response object.
Fixed Contract Name ERC721 Standard property ERC1155 Standard property

Tasks

  • Add controllers update
  • Update tests
  • Update snapshots (if necessary)

References

@gantunesr gantunesr requested a review from a team November 8, 2021 14:51
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 8, 2021
@Cal-L Cal-L mentioned this pull request Nov 9, 2021
Closed
@gantunesr gantunesr changed the title [FIX] Collectibles collection name [FIX] Minor NFTs bugs Nov 17, 2021
@gantunesr gantunesr mentioned this pull request Nov 17, 2021
Closed
Cal-L
Cal-L reviewed Nov 22, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left same comments regarding blocking PR. Awaiting that PR to be merged.

app/core/Engine.js Outdated Show resolved Hide resolved
app/core/Engine.js Outdated Show resolved Hide resolved
@gantunesr gantunesr requested a review from Cal-L November 26, 2021 13:34
@mobularay mobularay removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 30, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 30, 2021
cortisiko
cortisiko approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Dec 1, 2021
Gustavo Antunes added 10 commits December 1, 2021 18:28
Merge branch 'develop' into refactor/collectibles-contract
64511b4
Update controllers version
e9fc789
Merge branch 'refactor/collectibles-contract' of https://github.com/M…
735484b 
…etaMask/metamask-mobile into refactor/collectibles-contract
Merge branch 'develop' into refactor/collectibles-contract
3a835a0
Upgrade controllers
4b21c40
Merge branch 'refactor/collectibles-contract' of https://github.com/M…
c7134a1 
…etaMask/metamask-mobile into refactor/collectibles-contract
Upgrade controllers
bff56aa
Merge branch 'develop' of https://github.com/MetaMask/metamask-mobile …
8b5204e 
…into refactor/collectibles-contract
Merge branch 'refactor/collectibles-contract' of https://github.com/M…
354fae3 
…etaMask/metamask-mobile into refactor/collectibles-contract
Update yarn lock
5030322
Cal-L
Cal-L approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 3eedff8 into develop Dec 3, 2021
@gantunesr gantunesr deleted the refactor/collectibles-contract branch December 3, 2021 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@gantunesr gantunesr

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gantunesr @Cal-L @cortisiko @mobularay @adonesky1