[GasController] Check for undefined basefeePerGas #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
reviewed
Mar 3, 2022
done |
|
Looks like this is out of date, would you mind rebasing? Thanks. |
|
@peak3d Apologies — do you mind rebasing this again? I will make sure to get this in today. |
NP, but I guess I'll have to rebase one of my two commits depending which one you merge first because they affect the same file..... |
soralit
pushed a commit
to KeystoneHQ/controllers
that referenced
this pull request
Mar 14, 2022
go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer:
```
type feeHistoryResult struct {
OldestBlock *hexutil.Big `json:"oldestBlock"`
Reward [][]*hexutil.Big `json:"reward,omitempty"`
BaseFee []*hexutil.Big `json:"baseFeePerGas,omitempty"` <---
GasUsedRatio []float64 `json:"gasUsedRatio"`
}
```
Current code checks for baseFeePerGas.length > 0 without checking for the occurence of this element.
This leads to an exception and in later flow to fallback to eth_gasPrice mode
FIXED: no feeMarket mode available in case one of past requests return no results
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer:
```
type feeHistoryResult struct {
OldestBlock *hexutil.Big `json:"oldestBlock"`
Reward [][]*hexutil.Big `json:"reward,omitempty"`
BaseFee []*hexutil.Big `json:"baseFeePerGas,omitempty"` <---
GasUsedRatio []float64 `json:"gasUsedRatio"`
}
```
Current code checks for baseFeePerGas.length > 0 without checking for the occurence of this element.
This leads to an exception and in later flow to fallback to eth_gasPrice mode
FIXED: no feeMarket mode available in case one of past requests return no results
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer:
```
type feeHistoryResult struct {
OldestBlock *hexutil.Big `json:"oldestBlock"`
Reward [][]*hexutil.Big `json:"reward,omitempty"`
BaseFee []*hexutil.Big `json:"baseFeePerGas,omitempty"` <---
GasUsedRatio []float64 `json:"gasUsedRatio"`
}
```
Current code checks for baseFeePerGas.length > 0 without checking for the occurence of this element.
This leads to an exception and in later flow to fallback to eth_gasPrice mode
FIXED: no feeMarket mode available in case one of past requests return no results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
GasController: Don't fall back to eth_gasPrice if node returns empty fee history
Description
go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer:
Current code checks for
baseFeePerGas.length > 0without checking for the occurence of this element.This leads to an exception and in later flow to fallback to eth_gasPrice mode
no feeMarket mode available in case one of past requests return no results
Checklist
Issue