-
-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GasController] Check for undefined basefeePerGas (#703)
go-ethereum based chains never return empty baseFeePerGas because this is omitted in the serializer: ``` type feeHistoryResult struct { OldestBlock *hexutil.Big `json:"oldestBlock"` Reward [][]*hexutil.Big `json:"reward,omitempty"` BaseFee []*hexutil.Big `json:"baseFeePerGas,omitempty"` <--- GasUsedRatio []float64 `json:"gasUsedRatio"` } ``` Current code checks for baseFeePerGas.length > 0 without checking for the occurence of this element. This leads to an exception and in later flow to fallback to eth_gasPrice mode FIXED: no feeMarket mode available in case one of past requests return no results
- Loading branch information
Showing
2 changed files
with
24 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters