Custom network + IPFS support (#616)

Add support for custom networks and IPFS urls
MetaMask · Oct 11, 2023 · 5779f3c · 5779f3c
1 parent f21b66a
commit 5779f3c
Show file tree

Hide file tree

Showing 9 changed files with 347 additions and 111 deletions.
diff --git a/src/assets/AssetsContractController.test.ts b/src/assets/AssetsContractController.test.ts
@@ -67,13 +67,17 @@ describe('AssetsContractController', () => {
     expect(tokenId).toStrictEqual('https://api.godsunchained.com/card/0');
   });
 
-  it('should return empty string as URI when address given is not an ERC-721 collectible', async () => {
+  it('should throw an error when address given is not an ERC-721 collectible', async () => {
     assetsContract.configure({ provider: MAINNET_PROVIDER });
-    const tokenId = await assetsContract.getCollectibleTokenURI(
-      '0x0000000000000000000000000000000000000000',
-      '0',
-    );
-    expect(tokenId).toStrictEqual('');
+    const result = async () => {
+      await assetsContract.getCollectibleTokenURI(
+        '0x0000000000000000000000000000000000000000',
+        '0',
+      );
+    };
+
+    const error = 'Contract does not support ERC721 metadata interface.';
+    await expect(result).rejects.toThrow(error);
   });
 
   it('should get ERC-721 collectible name', async () => {

diff --git a/src/assets/AssetsDetectionController.test.ts b/src/assets/AssetsDetectionController.test.ts
@@ -447,6 +447,7 @@ describe('AssetsDetectionController', () => {
         description: 'Description 2573',
         image: 'image/2573.png',
         name: 'ID 2573',
+        standard: 'ERC721',
       },
     );
     await assetsDetection.detectCollectibles();
@@ -456,6 +457,7 @@ describe('AssetsDetectionController', () => {
         description: 'Description 2573',
         image: 'image/2573.png',
         name: 'ID 2573',
+        standard: 'ERC721',
         tokenId: '2573',
       },
       {

diff --git a/src/assets/CollectibleStandards/ERC721/ERC721Standard.ts b/src/assets/CollectibleStandards/ERC721/ERC721Standard.ts
@@ -76,7 +76,7 @@ export class ERC721Standard {
       contract,
     );
     if (!supportsMetadata) {
-      return '';
+      throw new Error('Contract does not support ERC721 metadata interface.');
     }
     return new Promise<string>((resolve, reject) => {
       contract.tokenURI(tokenId, (error: Error, result: string) => {