Expose WebSocket for network access (#696)

* Expose XMLHttpRequest for network access endowment * Add WebSocket * Fix linting * Remove XmlHttpRequest since its not available in Node.js
MetaMask · Oct 11, 2023 · 7f73e5c · 7f73e5c
1 parent a90b102
commit 7f73e5c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/permissions/endowments/network-access.test.ts b/src/permissions/endowments/network-access.test.ts
@@ -13,6 +13,9 @@ describe('endowment:network-access', () => {
       allowedCaveats: null,
     });
 
-    expect(specification.endowmentGetter()).toStrictEqual(['fetch']);
+    expect(specification.endowmentGetter()).toStrictEqual([
+      'fetch',
+      'WebSocket',
+    ]);
   });
 });
diff --git a/src/permissions/endowments/network-access.ts b/src/permissions/endowments/network-access.ts
@@ -10,7 +10,7 @@ const permissionName = 'endowment:network-access';
 type NetworkAccessEndowmentSpecification = ValidPermissionSpecification<{
   permissionType: PermissionType.Endowment;
   targetKey: typeof permissionName;
-  endowmentGetter: (_options?: any) => ['fetch'];
+  endowmentGetter: (_options?: any) => ['fetch', 'WebSocket'];
   allowedCaveats: null;
 }>;
 
@@ -32,7 +32,7 @@ const specificationBuilder: PermissionSpecificationBuilder<
     targetKey: permissionName,
     allowedCaveats: null,
     endowmentGetter: (_getterOptions?: EndowmentGetterParams) => {
-      return ['fetch'];
+      return ['fetch', 'WebSocket'];
     },
   };
 };