fix: use type unknown instead of Keyring

MetaMask · May 25, 2023 · a0f250d · a0f250d
1 parent e060796
commit a0f250d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/keyring-controller/src/KeyringController.test.ts b/packages/keyring-controller/src/KeyringController.test.ts
@@ -449,9 +449,14 @@ describe('KeyringController', () => {
     describe('when existing type is provided', () => {
       it('should return keyrings of the right type', async () => {
         await withController(async ({ controller }) => {
-          const keyrings = controller.getKeyringsByType(KeyringTypes.hd);
+          const keyrings = controller.getKeyringsByType(
+            KeyringTypes.hd,
+          ) as KeyringObject[];
           expect(keyrings).toHaveLength(1);
           expect(keyrings[0].type).toBe(KeyringTypes.hd);
+          expect(keyrings[0].getAccounts()).toStrictEqual(
+            controller.state.keyrings[0].accounts.map(normalize),
+          );
         });
       });
     });

diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts
@@ -395,7 +395,7 @@ export class KeyringController extends BaseController<
    * @param type - Keyring type name.
    * @returns An array of keyrings of the given type.
    */
-  getKeyringsByType(type: KeyringTypes | string): Keyring[] {
+  getKeyringsByType(type: KeyringTypes | string): unknown[] {
     return this.#keyring.getKeyringsByType(type);
   }