fix: fix

MetaMask · Dec 19, 2023 · cd65d96 · cd65d96
1 parent 9ff9e45
commit cd65d96
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 14 deletions.
diff --git a/packages/assets-controllers/src/token-prices-service/codefi-v2.test.ts b/packages/assets-controllers/src/token-prices-service/codefi-v2.test.ts
@@ -58,7 +58,7 @@ describe('CodefiTokenPricesServiceV2', () => {
       });
     });
 
-    it('throws if one of the token addresses cannot be found in the response data', async () => {
+    it('should not throw if one of the token addresses cannot be found in the response data', async () => {
       nock('https://price-api.metafi.codefi.network')
         .get('/v2/chains/1/spot-prices')
         .query({
@@ -74,13 +74,28 @@ describe('CodefiTokenPricesServiceV2', () => {
           },
         });
 
-      await expect(
-        new CodefiTokenPricesServiceV2().fetchTokenPrices({
-          chainId: '0x1',
-          tokenAddresses: ['0xAAA', '0xBBB', '0xCCC'],
+      const result = await new CodefiTokenPricesServiceV2().fetchTokenPrices({
+        chainId: '0x1',
+        tokenAddresses: ['0xAAA', '0xBBB', '0xCCC'],
+        currency: 'ETH',
+      });
+      expect(result).toStrictEqual({
+        '0xAAA': {
+          tokenAddress: '0xAAA',
+          value: undefined,
           currency: 'ETH',
-        }),
-      ).rejects.toThrow('Could not find price for "0xAAA" in "ETH"');
+        },
+        '0xBBB': {
+          tokenAddress: '0xBBB',
+          value: 33689.98134554716,
+          currency: 'ETH',
+        },
+        '0xCCC': {
+          tokenAddress: '0xCCC',
+          value: 148.1344197578456,
+          currency: 'ETH',
+        },
+      });
     });
 
     it('throws if the currency cannot be found in the response data', async () => {
@@ -100,13 +115,29 @@ describe('CodefiTokenPricesServiceV2', () => {
           },
         });
 
-      await expect(
-        new CodefiTokenPricesServiceV2().fetchTokenPrices({
-          chainId: '0x1',
-          tokenAddresses: ['0xAAA', '0xBBB', '0xCCC'],
+      const result = await new CodefiTokenPricesServiceV2().fetchTokenPrices({
+        chainId: '0x1',
+        tokenAddresses: ['0xAAA', '0xBBB', '0xCCC'],
+        currency: 'ETH',
+      });
+
+      expect(result).toStrictEqual({
+        '0xAAA': {
+          tokenAddress: '0xAAA',
+          value: undefined,
           currency: 'ETH',
-        }),
-      ).rejects.toThrow('Could not find price for "0xAAA" in "ETH"');
+        },
+        '0xBBB': {
+          tokenAddress: '0xBBB',
+          value: 33689.98134554716,
+          currency: 'ETH',
+        },
+        '0xCCC': {
+          tokenAddress: '0xCCC',
+          value: 148.1344197578456,
+          currency: 'ETH',
+        },
+      });
     });
 
     it('throws if the request fails consistently', async () => {

diff --git a/packages/assets-controllers/src/token-prices-service/codefi-v2.ts b/packages/assets-controllers/src/token-prices-service/codefi-v2.ts
@@ -348,7 +348,8 @@ export class CodefiTokenPricesServiceV2
           ];
 
         if (!price) {
-          throw new Error(
+          // console error instead of throwing to not interrupt the fetching of other tokens in case just one fails
+          console.error(
             `Could not find price for "${tokenAddress}" in "${currency}"`,
           );
         }