Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the extension ENS controller with the core ENS controller #1129

Closed
4 tasks
Gudahtt opened this issue Mar 15, 2023 · 2 comments · Fixed by #1170
Closed
4 tasks

Merge the extension ENS controller with the core ENS controller #1129

Gudahtt opened this issue Mar 15, 2023 · 2 comments · Fixed by #1170
Assignees
Labels

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Mar 15, 2023

MetaMask mobile and extension both have ENS controllers, but they have separate implementations and even separate purposes.

The mobile ENS controller (here in the core repository) handles ENS lookups and caches the responses. Extension does not use a controller for this; the lookups are performed in the UI and not cached.

The extension ENS controller performs reverse ENS lookups, resolving an address to an ENS name. Mobile doesn't seem to have this feature, though I'm not certain.

Both projects would benefit from both features. We can merge the two into a shared ENS controller that supports forward and reverse ENS lookups with caching for both.

Definition of Done

  • Whenever applies, any change unit tested, reviewed(approved) and documented(JSDOC at least)
  • We have changelog entries for any related changes
  • Any changed APIs have comprehensive inline documentation
  • Any changed public APIs are well covered by unit tests
  • Other items
  • If a planning/research ticket, then the plan has been reviewed and approved by at least 1 team members
@Gudahtt Gudahtt added the enhancement New feature or request label Mar 15, 2023
@xinnanyemm
Copy link

Hey team! Please add your planning poker estimate with Zenhub @cryptodev-2s @Gudahtt @mikesposito

@legobeat
Copy link
Contributor

Relevant when considering the future development of this controller: MetaMask/specifications#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants