Merge extension ens controller #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mcmire
reviewed
Apr 6, 2023
There was a problem hiding this comment.
It seems like even if we're bringing code from the extension we can use this opportunity to clean things up a bit. My suggestions below are mainly geared toward that end. However it also seems that there are other changes here that we might not want just yet.
|
Related: MetaMask/metamask-extension#18035 Something to consider bringing in here as well, or better saved for a follow-up? |
6 tasks
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
from
6f8caf4
to
8b80cd4
Compare
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
|
@legobeat Thanks for linking that PR, I wasn't aware of that. I looked through the PR and it doesn't seem to change the controller itself, so I think we should take care of that in a followup PR. |
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
from
b408e1f
to
5f5847f
Compare
|
@cryptodev-2s Just FYI, looks like the newest changes are failing the lint step. There's also the outstanding questions I have above. Let me know if my comments make sense or if you want to meet briefly to discuss them. |
Gudahtt
reviewed
Apr 17, 2023
Gudahtt
reviewed
Apr 17, 2023
Gudahtt
reviewed
Apr 17, 2023
Gudahtt
reviewed
Apr 17, 2023
|
@cryptodev-2s If you push up the changes you were showing me today then I can help you tweak this further! |
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
4 times, most recently
from
42346e8
to
704b617
Compare
cryptodev-2s
commented
Apr 18, 2023
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
from
69af306
to
ec95052
Compare
Gudahtt
reviewed
Apr 18, 2023
cryptodev-2s
changed the title
cryptodev-2s
changed the title
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Apr 20, 2023
packages/transaction-controller/src/TransactionController.test.ts
Outdated
Show resolved
Hide resolved
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
from
08f49ec
to
f76e0d5
Compare
cryptodev-2s
force-pushed
the
feature/merge-extension-ens-controller
branch
from
f76e0d5
to
c04737f
Compare
Gudahtt
reviewed
Apr 20, 2023
Gudahtt
previously approved these changes
Apr 20, 2023
Gudahtt
approved these changes
Apr 20, 2023
cryptodev-2s
commented
Apr 20, 2023
Merged
Gudahtt
added a commit
that referenced
this pull request
May 10, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
Gudahtt
added a commit
that referenced
this pull request
May 10, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
3 tasks
Gudahtt
added a commit
that referenced
this pull request
May 10, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
Gudahtt
added a commit
that referenced
this pull request
May 10, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Merge extension ens controller
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Merge extension ens controller
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The network change handler for the ENS controller has been broken since the PR #1170 due to a conflict with #1196, which was merged around the same time. It referenced the `network` property of the network state that we have removed. The change handler has been updated to use `networkId` instead. Additionally, the `NetworkState` type has been imported so that we're less likely to make this mistake again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the extension ens controller with the core ens controller
Fix issue #1129