bugfix: add collectible original image #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
approved these changes
May 13, 2019
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
Bump ethereumjs/tx to 4.1.2
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
### Changed - The `Keyring` exposes a new optional method `init` ([MetaMask#99](MetaMask/utils#99)) ### Fixed - Bump `@ethereumjs/tx` to `4.1.2` to address runtime compatibility issues ([MetaMask#100](MetaMask/utils#100))
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
This PR updates various repository features for module template compliance. This repository should be fully compliant as of this PR, except for tests, which will be addressed in a follow-up. Notable changes include: - Updates the ESLint config and related dependencies - Adds `@lavamoat/allow-scripts` and the `setup` package script - Migrates from CircleCI to GitHub Actions - Bumps the minimum Node version to 14
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing QA of this previous PR #99, noticed that there was method without change. The original bug was solved (when auto detecting assets), but it was still there for manually added a collectible. Added types to make sure this won't happen again.