Export isTokenDetectionSupportedForNetwork function
#1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `isTokenDetectionSupportedForNetwork` is now exported from the `assets-controllets` package. This function was exported from the `utils` before this repository was split into separate packages. This function is used in `metamask-mobile`.
3 tasks
Gudahtt
deleted the
export-function-is-token-detection-supported-for-network
branch
Merged
Gudahtt
added a commit
that referenced
this pull request
Dec 20, 2022
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The function `isTokenDetectionSupportedForNetwork` is now exported from the `assets-controllets` package. This function was exported from the `utils` before this repository was split into separate packages. This function is used in `metamask-mobile`. - CHANGED: - [assets-controllers]: Export the function `isTokenDetectionSupportedForNetwork` **Checklist** - [x] Tests are included if applicable - [x] Any added code is fully documented
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The function `isTokenDetectionSupportedForNetwork` is now exported from the `assets-controllets` package. This function was exported from the `utils` before this repository was split into separate packages. This function is used in `metamask-mobile`. - CHANGED: - [assets-controllers]: Export the function `isTokenDetectionSupportedForNetwork` **Checklist** - [x] Tests are included if applicable - [x] Any added code is fully documented
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
isTokenDetectionSupportedForNetworkis now exported from theassets-controlletspackage. This function was exported from theutilsbefore this repository was split into separate packages. This function is used inmetamask-mobile.CHANGED:
isTokenDetectionSupportedForNetworkChecklist