Simplify composable controller tests #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composable controller tests have been simplified. They no longer use real controllers, instead using mock controllers defined in the test module. This should reduce the churn we've been seeing in these tests as we make breaking changes to controllers.
adonesky1
reviewed
Jan 24, 2023
packages/composable-controller/src/ComposableController.test.ts
Outdated
Show resolved
Hide resolved
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The composable controller tests have been simplified. They no longer use real controllers, instead using mock controllers defined in the test module. This should reduce the churn we've been seeing in these tests as we make breaking changes to controllers. **Checklist** - [x] Tests are included if applicable - [x] Any added code is fully documented
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The composable controller tests have been simplified. They no longer use real controllers, instead using mock controllers defined in the test module. This should reduce the churn we've been seeing in these tests as we make breaking changes to controllers. **Checklist** - [x] Tests are included if applicable - [x] Any added code is fully documented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composable controller tests have been simplified. They no longer use real controllers, instead using mock controllers defined in the test module.
This should reduce the churn we've been seeing in these tests as we make breaking changes to controllers.
Checklist