Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 42.0.0 #1108

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Release 42.0.0 #1108

merged 8 commits into from
Feb 17, 2023

Conversation

hmalik88
Copy link
Contributor

This release includes a breaking change to controller-utils, phishing-controller and transaction-controller. isomorphic-fetch has been now removed. This was breaking snaps that implicitly import controller-utils if they did not have a network endowment.

@hmalik88 hmalik88 requested a review from a team as a code owner February 17, 2023 17:59
@Gudahtt
Copy link
Member

Gudahtt commented Feb 17, 2023

Hmm, we need to release all packages I think. If not, they'll still be using the old version of controller-utils with isomorphic-fetch.

mcmire
mcmire previously approved these changes Feb 17, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a single missing change entry!

@Gudahtt Gudahtt changed the title Release/42.0.0 Release 42.0.0 Feb 17, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmalik88 hmalik88 merged commit dc9eb67 into main Feb 17, 2023
@hmalik88 hmalik88 deleted the release/42.0.0 branch February 17, 2023 22:20
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Release 42.0.0

* update changelogs

* update formatting

* updated all packages

* more updates

* updates per comments

* changelog fixes

* more changes per comments
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Release 42.0.0

* update changelogs

* update formatting

* updated all packages

* more updates

* updates per comments

* changelog fixes

* more changes per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants