Update name of tokens on token list #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommasini
changed the title
…e on TokenRatesController
mcmire
reviewed
Mar 20, 2023
|
Thanks for the review @mcmire I will address your comments later today |
Gudahtt
reviewed
Mar 23, 2023
|
The next step on this PR is to implement the responsibility of the update of the tokens name on the TokensController instead of the TokenDetectionController More context on this thread |
|
@tommasini Cool, just post another comment when you're ready for review again! |
bergarces
reviewed
Jun 30, 2023
legobeat
reviewed
Jul 4, 2023
legobeat
reviewed
Jul 4, 2023
legobeat
reviewed
Jul 4, 2023
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
legobeat
approved these changes
Jul 7, 2023
3 tasks
8 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
BREAKING:to the start of the PR title.
Description
This PR aims to update the token name of the tokens on the token list.
It was added the name property on the follow function:
addToken- now it receives an object with optional params (name, image)addTokensIt was created a new function called
updateTokensAttribute- It aims to update the tokens attribute to the tokens that are on the state with the fetched token list.It was created a new ERC20 standard to get the token name
getTokenNameand the function to call it on Assets Controller
getERC20TokenNameChecklist
Issue
Resolves #???