Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the ENS controller to the BaseController v2 API #1134

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Mar 16, 2023

This PR migrate the ens controller to new base api
Related issue #1130

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner March 16, 2023 15:44
@cryptodev-2s cryptodev-2s changed the title migrate ens controller to base api v2 Convert the ENS controller to the BaseController v2 API Mar 16, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@cryptodev-2s cryptodev-2s merged commit 045bedb into main Mar 17, 2023
@cryptodev-2s cryptodev-2s deleted the feature/migrate-ens-controller-to-base-api-v2 branch March 17, 2023 23:41
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Convert the ENS controller to the BaseController v2 API
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Convert the ENS controller to the BaseController v2 API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants