Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PermittedHandlerExport to permission-controller #1184

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add PermittedHandlerExport to permission-controller #1184

wants to merge 4 commits into from

Commits on Apr 28, 2023

  1. Use @metamask/json-rpc-engine, @metamask/rpc-errors, and `@metama… 

    …sk/utils` in `permission-controller`

In order to remove the dependency on `@metamask/types` inside `snaps-monorepo`, we need the `PermittedHandlerExport` type. This type depends on types from the `@metamask/json-rpc-engine` package, which were previously duplicated inside `@metamask/types`. In this commit, I have moved `PermittedHandlerExport` to this package, which required bumping `@metamask/json-rpc-engine`, `@metamask/rpc-errors`, and `@metamask/utils`.
    @Mrtenz
    Mrtenz committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c92d254 View commit details
    Browse the repository at this point in the history

  2. Update "@metamask/rpc-errors" to version "^5.1.1" 

    This commit updates "@metamask/rpc-errors" package to version "^5.1.1" in package.json and yarn.lock files. This will resolve an issue related to an internal error in PermissionController caused by this dependency.
    @Mrtenz
    Mrtenz committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ecd9c6a View commit details
    Browse the repository at this point in the history

  3. Update packages/permission-controller/src/permitted-handler.ts 

    Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
    @Mrtenz @legobeat
    Mrtenz and legobeat committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    327803b View commit details
    Browse the repository at this point in the history

  4. Add a 'cause' field to error objects in tests 

    Some error objects should have a 'cause' field that will capture inner causes of particular errors.
    @Mrtenz
    Mrtenz committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f05f318 View commit details
    Browse the repository at this point in the history