Tokens controller approve reject refactor #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergarces
force-pushed
the
tokens-controller-approve-reject-refactor
branch
from
602ba37
to
308856f
Compare
bergarces
commented
May 4, 2023
| @@ -74,7 +70,7 @@ export type SuggestedAssetMetaBase = { | |||
| time: number; | |||
| type: string; | |||
| asset: Token; | |||
| interactingAddress?: string; | |||
| interactingAddress: string; | |||
There was a problem hiding this comment.
The only place where this object is created is in the method watchAsset and it uses:
interactingAddress: interactingAddress || selectedAddress
The value of selectedAddress is defined as a string, not string | undefined, so this value is never undefined.
bergarces
commented
May 4, 2023
| @@ -670,12 +663,10 @@ export class TokensController extends BaseController< | |||
| ): Promise<AssetSuggestionResult> { | |||
| const { selectedAddress } = this.config; | |||
|
|
|||
| const suggestedAssetMeta: SuggestedAssetMeta & { | |||
| interactingAddress: string; | |||
There was a problem hiding this comment.
No need to force this into the type anymore due to the type change.
vinistevam
approved these changes
May 9, 2023
matthewwalsh0
approved these changes
May 10, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* stops calling approve and reject from controller
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* stops calling approve and reject from controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops triggering the acceptance or rejection of the approval from within TokensController. That'll be the responsibility of the caller.
This is part of a series of tickets that aim to refactor and simplify how we await for the confirmation promise.
Changes
References
Checklist