Remove duplicate hasProperty function
#1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hasProperty` function in `@metamask/controller-utils` has been removed. Instead the `hasProperty` function from `@metamask/utils` is now used in its place. The `@metamask/utils` version of this function is functionally identical but has a better type signature. Relates to #1204
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `hasProperty` function in `@metamask/controller-utils` has been removed. Instead the `hasProperty` function from `@metamask/utils` is now used in its place. The `@metamask/utils` version of this function is functionally identical but has a better type signature. Relates to #1204
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `hasProperty` function in `@metamask/controller-utils` has been removed. Instead the `hasProperty` function from `@metamask/utils` is now used in its place. The `@metamask/utils` version of this function is functionally identical but has a better type signature. Relates to #1204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
hasPropertyfunction in@metamask/controller-utilshas been removed. Instead thehasPropertyfunction from@metamask/utilsis now used in its place. The@metamask/utilsversion of this function is functionally identical but has a better type signature.Changes
hasPropertyfunctionReferences
Relates to #1204
Checklist