Require Infura project ID

[Gudahtt]

Description

The network controller now requires an Infura project ID to be provided upon construction. This brings the network controller more in-line with the extension. Runtime validation has been added for the sake of making the merge with the extension network controller easier.

Changes

@metamask/network-controller

• BREAKING: The infuraProjectId constructor parameter is now required

References

Closes #1201

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[legobeat]

Is it possible to refrain from doing this and take it in the other direction? The goal should be that everything degrades gracefully without Infura connectivity or credentials as a first step, and long-term to make the codebase provider-agnostic and remove hardcoded references to specific providers on this level?.

[Gudahtt]

This constructor argument won't make a difference either way in terms of how baked-in the Infura networks are. This isn't meant to cement them further, just to improve validation and help us merge the two network controllers.

I'd like to remove the special handling of Infura providers as well but... that's not trivial (API changes, configuration, middleware differences, etc.). It'll be easier to tackle that when we have one network controller rather than two.

[legobeat]

It's easy to get the impression that this does cement the provider.. Here or another place good to add a // TODO: or // FIXME: on that the intention is that the controller will be made provider-agnostic?

[Gudahtt]

Sorry I should elaborate; the path to removing these would be to enhance the capabilities of our custom RPC configuration, such that it can be used to support our Infura networks as well.

We've already started down this path; the localhost e2e test network used to be baked-in, but now we use it as a custom network instead. And when we recently added Linea as a default network, it was added as a custom network.

That is, I'd expect us to delete the built-in networks completely rather than make them optional. Making them optional isn't need not be a step along the path to removing them.

It's long past time to track this work in an issue; I'll set a reminder to create one tomorrow.

[Gudahtt]

Issue created: #1279

[mcmire]

Looks good!