Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy method #1330

Merged
merged 4 commits into from
May 5, 2023
Merged

Add destroy method #1330

merged 4 commits into from
May 5, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented May 5, 2023 •
edited
Loading

Description

This PR adds the destroy method to stop the block tracker polling.

Changes

  • ADDED: destroy method

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito marked this pull request as ready for review May 5, 2023 09:56
@mikesposito mikesposito requested a review from a team as a code owner May 5, 2023 09:56
Gudahtt
Gudahtt previously approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito @Gudahtt
docs: apply description suggestion
7b7a6d4 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@mikesposito mikesposito merged commit f5c9830 into main May 5, 2023
@mikesposito mikesposito deleted the feat/networkcontroller-destroy branch May 5, 2023 11:49
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @Gudahtt @MajorLift
Add destroy method (#1330)
1aab47f 
* feat: add destroy method

* test: see if blockTracker is actually undefined

* docs: apply description suggestion

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mikesposito @Gudahtt @MajorLift
Add destroy method (#1330)
9001abb 
* feat: add destroy method

* test: see if blockTracker is actually undefined

* docs: apply description suggestion

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkController API normalization: Add destroy to NetworkController
2 participants
@mikesposito @Gudahtt