BREAKING: Remove namespaced permissions #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
remove-namespaced-permissions
branch
from
9bf9690
to
1ad521c
Compare
rekmarks
force-pushed
the
remove-namespaced-permissions
branch
from
a5ef4f3
to
1faa530
Compare
This comment was marked as resolved.
This comment was marked as resolved.
I don't see a good reason tbh, there hasn't been any meaningful changes since last release. |
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
brad-decker
pushed a commit
to dragana8/core
that referenced
this pull request
Jun 1, 2023
Removes namespaced permissions from the `PermissionController` for the reasons described in MetaMask#1323. As a consequence, also removes the notion of "target keys", which only existed to support namespaced methods. Controller state is not impacted by these changes. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Removes namespaced permissions from the `PermissionController` for the reasons described in #1323. As a consequence, also removes the notion of "target keys", which only existed to support namespaced methods. Controller state is not impacted by these changes. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Removes namespaced permissions from the `PermissionController` for the reasons described in #1323. As a consequence, also removes the notion of "target keys", which only existed to support namespaced methods. Controller state is not impacted by these changes. --------- Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes namespaced permissions from the
PermissionControllerfor the reasons described in #1323. As a consequence, also removes the notion of "target keys", which only existed to support namespaced methods. Controller state is not impacted by these changes.Changes
targetKeyconcepttargetKeyproperty of permission specifications has been renamed totargetName.References
Fixes #1323
Checklist