Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for @metamask/gas-fee-controller@6 #1405

Merged
merged 4 commits into from
Jun 3, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 31, 2023

Description

The changelog has been updated to better describe the changes. A new entry has been added for a newly discovered breaking change, and an existing entry was updated to clarify when it applies.

Changes

None

References

Relates to changes in #1329

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

The changelog has been updated to better describe the changes. A new
entry has been added for a newly discovered breaking change, and an
existing entry was updated to clarify when it applies.
@Gudahtt Gudahtt requested a review from a team as a code owner May 31, 2023 23:30
brad-decker
brad-decker previously approved these changes Jun 2, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing.

packages/gas-fee-controller/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt merged commit 2f3131d into main Jun 3, 2023
@Gudahtt Gudahtt deleted the clarify-gas-fee-controller-v6-changelog branch June 3, 2023 17:43
@mcmire
Copy link
Contributor

mcmire commented Jun 5, 2023

@Gudahtt Was just thinking about this again. Should I edit the GitHub release to include these changes as well?

MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Update changelog for `@metamask/gas-fee-controller@6`

The changelog has been updated to better describe the changes. A new
entry has been added for a newly discovered breaking change, and an
existing entry was updated to clarify when it applies.

* Fix typo

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Update changelog for `@metamask/gas-fee-controller@6`

The changelog has been updated to better describe the changes. A new
entry has been added for a newly discovered breaking change, and an
existing entry was updated to clarify when it applies.

* Fix typo

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants