Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent bug where incorrect symbol used for token rates #1496

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Prevent bug where incorrect symbol used for token rates #1496

merged 1 commit into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Prevent bug where incorrect symbol used for token rates 

    There is a bug present in the TokenRatesController where a network
switch can result in token rates being requested for the wrong network.

This can happen when the network state update event comes before
currency rate controller state update event. The controller only works
correctly if the currency rate controller state update event happens
first.

Instead of getting the ticker from the currency rate controller, we now
get it directly from the network controller. This simplifies the
controller and ensures that we always use the currency symbol
corresponding with the current chain ID.
    @Gudahtt
    Gudahtt committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    cef335c View commit details
    Browse the repository at this point in the history