Simplify TokenRatesController update test case
#1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TokenRatesController` test case for updating token rates has been simplifed by replacing controllers with stubs. The test was using a real `PreferencesController`, `NetworkController`, and `TokensController`.
legobeat
approved these changes
Jul 14, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `TokenRatesController` test case for updating token rates has been simplifed by replacing controllers with stubs. The test was using a real `PreferencesController`, `NetworkController`, and `TokensController`.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `TokenRatesController` test case for updating token rates has been simplifed by replacing controllers with stubs. The test was using a real `PreferencesController`, `NetworkController`, and `TokensController`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
TokenRatesControllertest case for updating token rates has been simplifed by replacing controllers with stubs. The test was using a realPreferencesController,NetworkController, andTokensController.References
This is tangentially related to #1466
Changelog
None
Checklist