Remove TokenRateController setters
#1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
token-rates-stop-polling-by-default
branch
from
bac0a6d
to
9dc6817
Compare
Gudahtt
force-pushed
the
remove-token-rate-controller-setters
branch
from
4c826b4
to
1a69576
Compare
Gudahtt
force-pushed
the
token-rates-stop-polling-by-default
branch
from
2224382
to
4ecf59d
Compare
Gudahtt
force-pushed
the
remove-token-rate-controller-setters
branch
from
1a69576
to
0bb28c8
Compare
Gudahtt
commented
Jul 14, 2023
The `TokenRateController` setters for `chainId` and `tokens` have been removed. These were confusing, unnecessary, and presented obstacles to testing asynchronous events triggered by these setters.
Gudahtt
force-pushed
the
remove-token-rate-controller-setters
branch
from
303fe77
to
5334002
Compare
Gudahtt
commented
Jul 14, 2023
| @@ -272,8 +272,7 @@ describe('TokenRatesController', () => { | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| tokenStateChangeListener!({ tokens: [], detectedTokens: [] }); | |||
|
|
|||
| // FIXME: This is now being called twice | |||
There was a problem hiding this comment.
Removing the setters fixed this bug! The configure call was triggering both the chain ID and the tokens setter, resulting in a double update
legobeat
approved these changes
Jul 14, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove `TokenRateController` setters The `TokenRateController` setters for `chainId` and `tokens` have been removed. These were confusing, unnecessary, and presented obstacles to testing asynchronous events triggered by these setters. * Fix token initialization * Lint fix
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove `TokenRateController` setters The `TokenRateController` setters for `chainId` and `tokens` have been removed. These were confusing, unnecessary, and presented obstacles to testing asynchronous events triggered by these setters. * Fix token initialization * Lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
TokenRateControllersetters forchainIdandtokenshave been removed. These were confusing, unnecessary, and presented obstacles to testing asynchronous events triggered by these setters.References
This is tangentially related to #1466
Changelog
@metamask/assets-controllersTokenRatecontrollersetter forchainIdandtokenspropertiesChecklist