Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide merged-packages/ from ESLint/Prettier #1524

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jul 18, 2023

Explanation

When we bring new libraries into this monorepo, we will first place them in merged-packages. This is a special directory we are creating that will be hidden from ESLint and Prettier (and also Yarn, since it's not in the set of known workspaces). This allows us to clean up the packages and get them passing the lint step before we properly move them to packages.

References

Relates to #1535.

Changelog

(N/A)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

When we bring new libraries into this monorepo, we will first place them
in `merged-packages`. This is a special directory we are creating that
will be hidden from ESLint and Prettier (and also Yarn, since it's not
in the set of known workspaces). This allows us to clean up the packages
and get them passing the lint step before we properly move them to
`packages`.
@mcmire mcmire marked this pull request as ready for review July 31, 2023 17:38
@mcmire mcmire requested a review from a team as a code owner July 31, 2023 17:38
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 4c21389 into main Aug 16, 2023
91 checks passed
@mcmire mcmire deleted the create-merged-packages branch August 16, 2023 19:36
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
When we bring new libraries into this monorepo, we will first place them
in `merged-packages`. This is a special directory we are creating that
will be hidden from ESLint and Prettier (and also Yarn, since it's not
in the set of known workspaces). This allows us to clean up the packages
and get them passing the lint step before we properly move them to
`packages`.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
When we bring new libraries into this monorepo, we will first place them
in `merged-packages`. This is a special directory we are creating that
will be hidden from ESLint and Prettier (and also Yarn, since it's not
in the set of known workspaces). This allows us to clean up the packages
and get them passing the lint step before we properly move them to
`packages`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants