eth-query ^2.1.2 -> @metamask/eth-query ^3.0.1 #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: eth-query@2.1.2 |
Mrtenz
previously approved these changes
Jul 21, 2023
The `eth-query` package does not ship with TypeScript type definitions, and none have been published under `@types/eth-query`. This results in TypeScript failing to build packages in this repo that want to use `eth-query`. We've attempted to mitigate this issue by adding our own type definitions for `eth-query` to this repo, but since they aren't included in the published version of the packages in question, it means that any other project that wants to use those packages must supply their own type definitions for `eth-query`. We have republished `eth-query` as `@metamask/eth-query`, which _does_ ship with type definitions. This removes the need for this repo or any consumers of these packages to provide their own.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `eth-query` package does not ship with TypeScript type definitions, and none have been published under `@types/eth-query`. This results in TypeScript failing to build packages in this repo that want to use `eth-query`. We've attempted to mitigate this issue by adding our own type definitions for `eth-query` to this repo, but since they aren't included in the published version of the packages in question, it means that any other project that wants to use those packages must supply their own type definitions for `eth-query`. We have republished `eth-query` as `@metamask/eth-query`, which _does_ ship with type definitions. This removes the need for this repo or any consumers of these packages to provide their own.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The `eth-query` package does not ship with TypeScript type definitions, and none have been published under `@types/eth-query`. This results in TypeScript failing to build packages in this repo that want to use `eth-query`. We've attempted to mitigate this issue by adding our own type definitions for `eth-query` to this repo, but since they aren't included in the published version of the packages in question, it means that any other project that wants to use those packages must supply their own type definitions for `eth-query`. We have republished `eth-query` as `@metamask/eth-query`, which _does_ ship with type definitions. This removes the need for this repo or any consumers of these packages to provide their own.
tommasini
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
eth-querypackage does not ship with TypeScript type definitions, and none have been published under@types/eth-query. This results in TypeScript failing to build packages in this repo that want to useeth-query. We've attempted to mitigate this issue by adding our own type definitions foreth-queryto this repo, but since they aren't included in the published version of the packages in question, it means that any other project that wants to use those packages must supply their own type definitions foreth-query.We have republished
eth-queryas@metamask/eth-query, which does ship with type definitions. This removes the need for this repo or any consumers of these packages to provide their own.Fixes #1471.
References
Changelog
@metamask/assets-controllerseth-query^2.1.2 with@metamask/eth-query^3.0.1eth-queryincludes TypeScript type definitions.@metamask/controller-utilseth-query^2.1.2 with@metamask/eth-query^3.0.1eth-queryincludes TypeScript type definitions.@metamask/gas-fee-controllereth-query^2.1.2 with@metamask/eth-query^3.0.1eth-queryincludes TypeScript type definitions.@metamask/network-controllereth-query^2.1.2 with@metamask/eth-query^3.0.1eth-queryincludes TypeScript type definitions.@metamask/transaction-controllereth-query^2.1.2 with@metamask/eth-query^3.0.1eth-queryincludes TypeScript type definitions.Checklist