Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend focused resolutions for preview builds #1631

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Aug 24, 2023

Explanation

When using a preview version, we don't want to replace the production version across the dependency tree; we only really want to target its direct usage by the project in question. This commit updates the instructions for using preview builds to ensure that this happens by asking the developer to include a specific version on the left-hand side of the resolution entry when updating package.json.

References

Relates to #1075.

Changelog

(No consumer-facing changes)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mcmire mcmire requested a review from a team as a code owner August 24, 2023 18:06
When using a preview version, we don't want to replace the production
version across the dependency tree; we only really want to target its
direct usage by the project in question. This commit updates the
instructions for using preview builds to ensure that this happens by
asking the developer include a specific version on the left-hand side of
the resolution entry when updating `package.json`.
@mcmire mcmire force-pushed the update-preview-builds-docs-2 branch from 81c4292 to abd45d4 Compare August 24, 2023 18:08
Gudahtt
Gudahtt previously approved these changes Aug 24, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 5e1e08a into main Aug 24, 2023
91 checks passed
@mcmire mcmire deleted the update-preview-builds-docs-2 branch August 24, 2023 18:20
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
When using a preview version, we don't want to replace the production
version across the dependency tree; we only really want to target its
direct usage by the project in question. This commit updates the
instructions for using preview builds to ensure that this happens by
asking the developer to include a specific version on the left-hand side of
the resolution entry when updating `package.json`.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
When using a preview version, we don't want to replace the production
version across the dependency tree; we only really want to target its
direct usage by the project in question. This commit updates the
instructions for using preview builds to ensure that this happens by
asking the developer to include a specific version on the left-hand side of
the resolution entry when updating `package.json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants