Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 78.0.0 #1708

Merged
merged 33 commits into from
Sep 26, 2023
Merged

Release 78.0.0 #1708

merged 33 commits into from
Sep 26, 2023

Conversation

OGPoyraz
Copy link
Member

See change logs

@OGPoyraz OGPoyraz requested a review from a team as a code owner September 25, 2023 10:09
@mikesposito
Copy link
Member

mikesposito commented Sep 25, 2023 •
edited
Loading

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

mikesposito
mikesposito reviewed Sep 25, 2023
View reviewed changes
packages/assets-controllers/CHANGELOG.md Outdated
Comment on lines 11 to 26
- **BREAKING**: `TokensController.addToken` now accepts a single options object
```
{
address: string;
symbol: string;
decimals: number;
name?: string;
image?: string;
interactingAddress?: string;
networkClientId?: NetworkClientId;
}
```
- **CHANGED**: `TokensController.addToken` will use the chain ID value derived from state for `networkClientId` if provided
- **CHANGED**: `TokensController.addTokens` now accepts an optional `networkClientId` as the last parameter
- **CHANGED**: `TokensController.addTokens` will use the chain ID value derived from state for `networkClientId` if provided
- **CHANGED**: `TokensController.watchAsset` options now accepts optional `networkClientId` which is used to get the ERC-20 token name if provided
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link PRs related to these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a4313b4

@OGPoyraz OGPoyraz changed the title Release/78.0.0 Release 78.0.0 Sep 25, 2023
@OGPoyraz
Copy link
Member Author

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

Thanks @mikesposito

jiexi
jiexi previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@jiexi jiexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metamask/asset-controllers LGTM. Thank you for cutting this release 💪

@Gudahtt
Copy link
Member

Gudahtt commented Sep 25, 2023

#1633 has been merged now as well, which includes many breaking changes. We'll need to expand the scope of this release to include a few more things

@jiexi
Copy link
Contributor

jiexi commented Sep 25, 2023

I'm working on getting #1633 included in this release right now

@jiexi jiexi requested a review from a team as a code owner September 25, 2023 21:20
@jiexi @Gudahtt
Update packages/assets-controllers/CHANGELOG.md
0cf5f03 
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
Gudahtt reviewed Sep 25, 2023
View reviewed changes
packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that each of these peer dependency bumps is just called a dependency bump in the change entry, which might be confusing (as that wouldn't normally be breaking). I've added a suggestion to re-word each one to "peer dependency"

packages/transaction-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/selected-network-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/gas-fee-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/ens-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
@Gudahtt Gudahtt merged commit 55b6636 into main Sep 26, 2023
103 checks passed
@Gudahtt Gudahtt deleted the release/78.0.0 branch September 26, 2023 12:20
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@OGPoyraz @adonesky1
@jiexi @Gudahtt @MajorLift
Release 78.0.0 (#1708)
854db80 
See change logs

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Jiexi Luan <jiexiluan@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@OGPoyraz @adonesky1
@jiexi @Gudahtt @MajorLift
Release 78.0.0 (#1708)
af67cfc 
See change logs

---------

Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Jiexi Luan <jiexiluan@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiexi jiexi jiexi left review comments

@mikesposito mikesposito mikesposito left review comments

@Gudahtt Gudahtt Gudahtt approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@OGPoyraz @mikesposito @Gudahtt @jiexi @Mrtenz @adonesky1