-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add name and symbol to getDetails #1727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Outdated
Show resolved
Hide resolved
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Outdated
Show resolved
Hide resolved
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Outdated
Show resolved
Hide resolved
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Show resolved
Hide resolved
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Show resolved
Hide resolved
salimtb
force-pushed
the
MMASSETS-28
branch
from
September 26, 2023 15:01
c3c2d3f
to
679548d
Compare
bergeron
previously approved these changes
Sep 26, 2023
bergeron
reviewed
Sep 26, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Show resolved
Hide resolved
sahar-fehri
previously approved these changes
Sep 28, 2023
adonesky1
reviewed
Nov 7, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Show resolved
Hide resolved
adonesky1
reviewed
Nov 7, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Outdated
Show resolved
Hide resolved
adonesky1
reviewed
Nov 8, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.ts
Outdated
Show resolved
Hide resolved
adonesky1
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change?
the function get details is not returning name and symbol , this mean that this information is not available in the extension for contract of type ERC1155, with this PR those two properties will be available
What is the solution your changes offer and how does it work?
the solution is to call the 2 method name() and symbol() in parallel , and if we get promise resolved we will include the result in the object returned.
Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
no
References
Changelog
@metamask/assets-controllers
Checklist