Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added options to PollingController to help handle cases where the Controller need more than just networkClientId #1776

Merged
merged 19 commits into from
Oct 11, 2023
Merged

Added options to PollingController to help handle cases where the Controller need more than just networkClientId #1776

merged 19 commits into from
Oct 11, 2023

Commits on Oct 4, 2023

  1. Added options to PollingController to help handle cases where the Con… 

    …troller need more than just networkClientId
    @shanejonas
    shanejonas committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    03e93b3 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Fixed feedback from PR around id variable name and expanding on tes… 

    …t to handle different options and stopping
    @shanejonas
    shanejonas committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    bf36d98 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into polling-controller-generic-options

    @shanejonas
    shanejonas authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    10d36e2 View commit details
    Browse the repository at this point in the history

  3. Update packages/polling-controller/src/PollingController.test.ts

    @shanejonas
    shanejonas authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7234504 View commit details
    Browse the repository at this point in the history

  4. Fixed test to match calls + renamed outerPollToken

    @shanejonas
    shanejonas committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2c0c219 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into polling-controller-generic-options

    @shanejonas
    shanejonas authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    472119d View commit details
    Browse the repository at this point in the history

  6. Fixed sorting for options to generate a unique key + fix type

    @shanejonas
    shanejonas committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f6fdd42 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fixed if statement around callbacks

    @shanejonas
    shanejonas committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    01192af View commit details
    Browse the repository at this point in the history

  2. Added JSDoc for getKey for PollingController

    @shanejonas
    shanejonas committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    556f1cf View commit details
    Browse the repository at this point in the history

  3. Update packages/polling-controller/src/PollingController.test.ts

    @shanejonas
    shanejonas authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b8c0e00 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into polling-controller-generic-options

    @shanejonas
    shanejonas authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ac6b7a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'main' into polling-controller-generic-options

    @shanejonas
    shanejonas authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4286bbc View commit details
    Browse the repository at this point in the history

  2. Added test case for different networkClientId + same options and fixe… 

    …d guards
    @shanejonas
    shanejonas committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4919cb3 View commit details
    Browse the repository at this point in the history

  3. Changed JSON.stringify to fast-json-stable-stringify

    @shanejonas
    shanejonas committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    95d54e8 View commit details
    Browse the repository at this point in the history

  4. Fixed linting

    @shanejonas
    shanejonas committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    585544e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Changed options type to Json and cleaned up naming of id/key for Poll… 

    …ingController
    @shanejonas
    shanejonas committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5da575d View commit details
    Browse the repository at this point in the history

  2. Update packages/polling-controller/src/PollingController.test.ts

    @shanejonas
    shanejonas authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bed5016 View commit details
    Browse the repository at this point in the history

  3. Fixed naming with #pollingTokenSets

    @shanejonas
    shanejonas committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d35f471 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into polling-controller-generic-options

    @adonesky1
    adonesky1 authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b689e51 View commit details
    Browse the repository at this point in the history