Parallelize network requests in assets controllers #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
|
I'm looking at the tests failing in CI. But so far they're passing locally. |
|
🚀 |
sahar-fehri
previously approved these changes
Oct 24, 2023
salimtb
previously approved these changes
Oct 24, 2023
adonesky1
reviewed
Oct 25, 2023
adonesky1
reviewed
Oct 25, 2023
adonesky1
reviewed
Oct 25, 2023
packages/assets-controllers/src/Standards/NftStandards/ERC721/ERC721Standard.ts
Show resolved
Hide resolved
bergeron
dismissed stale reviews from adonesky1, salimtb, and sahar-fehri
via
18d4131
|
Some NFT tests (the |
adonesky1
approved these changes
Oct 26, 2023
mcmire
pushed a commit
that referenced
this pull request
Nov 2, 2023
## Explanation Parallelizes network requests in assets controllers for better performance. I see each non-cached RPC request taking ~50ms on fast internet, and ~500ms on 3g internet. Parallelizing requests where possible causes a noticeable performance improvement. For example, getting details for an ERC-721 NFT in parallel benchmarks ~100ms quicker on fast internet, and ~600ms faster on 3g internet. ## Changelog ### `@metamask/assets-controllers` - **FIXED**: Parallelized network requests for better performance ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex Donesky <adonesky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Parallelizes network requests in assets controllers for better performance.
I see each non-cached RPC request taking ~50ms on fast internet, and ~500ms on 3g internet. Parallelizing requests where possible causes a noticeable performance improvement. For example, getting details for an ERC-721 NFT in parallel benchmarks ~100ms quicker on fast internet, and ~600ms faster on 3g internet.
Changelog
@metamask/assets-controllersChecklist