Fix issue where @metamask/polling-controller was mistakenly omitted from @metamask/assets-controller dependencies #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom @metamask/assets-controller dependencies
adonesky1
referenced
this pull request
Oct 12, 2023
…PollingController` (#1763) Resolves: MetaMask/MetaMask-planning#1032 Integrates new `PollingController` abstraction into the `TokenListController`, implements the `executePoll` method and parameterizes the `fetchTokenList` method by `networkClientId` such that tokenLists can be fetched and cached for different networks via concurrent polling sessions. **A note:** As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root `tokenList` state but rather access from the cache with a chainId selector.
Merged
shanejonas
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where
@metamask/polling-controllerwas mistakenly omitted from@metamask/assets-controllerdependencies