-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move json-rpc-engine from merged-packages to packages #1895
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/jest@29.5.7 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finished testing the tag porting script, and I think it will be safer to run it before the package is moved out of merged-packages/
.
So #1802 will need to be merged before this PR can be merged. Sorry for the confusion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags have been successfully ported to core!
- Example tag diff link from CHANGELOG: https://github.com/MetaMask/core/compare/json-rpc-engine@6.1.0...@metamask/json-rpc-engine@7.0.0
- Verify full list with this command:
git ls-remote --tags origin | grep 'json-rpc-engine'
Note: Some earlier release commits that were untagged in the original repo have been skipped by the tag porting script, and will be tagged manually.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed PermissionController diff
"@metamask/rpc-errors": "^6.1.0", | ||
"@metamask/utils": "^8.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this package being downgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! I just pushed a fix.
I'll add an entry in the migration checklist to double-check for dependency version bumps or other changes in main that may have happened while the PR is open.
For future migrations, we plan to coordinate to minimize the time these PRs are kept open so there's less chance of something like this slipping through.
14aad4d
to
565530d
Compare
565530d
to
71c1e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR description to mention the dependency changes to other packages being made here. This looks good.
Explanation
In the process of migrating json-rpc-engine into core monorepo. In this PR we are moving json-rpc-engine from
merged-packages
topackages
folder.In this process, we followed below steps.
Moving to
packages
yarn workspace @metamask/json-rpc-engine test
.Update downstream repos
Lints and Constraints
yarn constraints
errorsyarn workspace @metamask/json-rpc-engine changelog:validate
References
Changelog Changes
@metamask/eth-json-rpc-provider
@metamask/json-rpc-engine
to ^7.2.0@metamask/json-rpc-engine
@metamask/utils
to ^8.2.0@metamask/network-controller
@metamask/json-rpc-engine
to ^7.2.0@metamask/permission-controller
@metamask/json-rpc-engine
to ^7.2.0@metamask/queued-request-controller
@metamask/json-rpc-engine
to ^7.2.0@metamask/selected-network-controller
@metamask/json-rpc-engine
to ^7.2.0Checklist