Add optional networkClientId and userAddress args to remaining NftController public methods
#2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
changed the title
networkClientId and userAddress args to remaining NftController public methods
adonesky1
force-pushed
the
add-missing-nft-controller-multichain-updates
branch
3 times, most recently
from
b1d2243
to
6a6b6cc
Compare
…oller public methods
adonesky1
force-pushed
the
add-missing-nft-controller-multichain-updates
branch
2 times, most recently
from
522997c
to
4a9ea83
Compare
adonesky1
force-pushed
the
add-missing-nft-controller-multichain-updates
branch
from
df2879d
to
49563a6
Compare
adonesky1
force-pushed
the
add-missing-nft-controller-multichain-updates
branch
from
ff487e7
to
d59dc18
Compare
adonesky1
force-pushed
the
add-missing-nft-controller-multichain-updates
branch
from
d59dc18
to
c235299
Compare
jiexi
reviewed
Nov 13, 2023
jiexi
reviewed
Nov 13, 2023
jiexi
reviewed
Nov 13, 2023
jiexi
reviewed
Nov 13, 2023
jiexi
reviewed
Nov 13, 2023
jiexi
reviewed
Nov 13, 2023
shanejonas
reviewed
Nov 13, 2023
| }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore-next-line |
There was a problem hiding this comment.
what are we ignoring about the next line?
There was a problem hiding this comment.
a type error, watchNft expects the tokenId in the first arg object to be a string. We're ignoring it precisely to test that the error is thrown for this case, since we currently don't enforce types in the extension where this is called.
There was a problem hiding this comment.
you could cast the fn to any or equivalent type instead:
const erc721Result = (nftController.watchNft as any)(ERC721_NFT, type);
There was a problem hiding this comment.
yep that would also work. Happy to do that if you think its better. Seems kindof the same to me
|
Most of these changes should be marked as BREAKING |
BelfordZ
reviewed
Nov 14, 2023
| @@ -17,10 +17,10 @@ module.exports = merge(baseConfig, { | |||
| // An object that configures minimum threshold enforcement for coverage results | |||
| coverageThreshold: { | |||
| global: { | |||
| branches: 87.77, | |||
| branches: 88.2, | |||
BelfordZ
reviewed
Nov 14, 2023
BelfordZ
reviewed
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/assets-controllersChanged:
watchNft,removeNft,removeAndIgnoreNft,removeNftContract,updateNftFavoriteStatus, andcheckAndUpdateAllNftsOwnershipStatusmethods onNftControllerall now accept an optional options object argument containingnetworkClientIdanduserAddressto identify where in state to mutate.addNftno longer accepts achainIdproperty in its options argument since this value can be retrieved by thenetworkClientIdproperty and is therefore redundant.addNftVerifyOwnershipmethod, have been replaced with an options object containing optional propertiesnetworkClientId,userAddressandsource. This method signature is more aligned with the options pattern for passingnetworkClientIdanduserAddresson this controller and elsewhere.checkAndUpdateSingleNftOwnershipStatuson NftController no longer accepts achainIdin its options argument. This is replaced with an optionalnetworkClientIdproperty which can be used to fetch chainId.*BREAKING: The fourth argument of the
isNftOwnermethod onNftControlleris now an options object with an optionalnetworkClientIdproperty. This method signature is more aligned with the options pattern for passingnetworkClientIdon this controller and elsewhere.validateWatchNftmethod onNftControlleris now private.detectNftsonNftDetectionControllernow accepts a single object argument with optional propertiesnetworkClientIdanduserAddress, rather than taking these as two sequential arguments.