Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel-runtime dependency required by ethjs-query #341

Merged
merged 3 commits into from
Feb 11, 2021

Commits on Feb 11, 2021

  1. Add babel-runtime dependency required by ethjs-query

    The version of `ethjs-query` we're using has an unlisted dependency
    upon `babel-runtime`, and will crash if it's not present. Currently
    it's working because `babel-runtime` is being brought in by another
    dependency (`fetch-mock`), but that dependency is removed in another
    PR (#340).
    
    Until we can migrate away from using this version of `ethjs-query`,
    `babel-runtime` has been added as an explicit dependency to ensure it
    is present.
    
    `ethjs-query` is a transitive dependency of `eth-method-registry` via
    `ethjs`. There is a PR open on `eth-method-registry` to replace `ethjs`
    altogether [1]. Once those are merged and released, we can update
    `eth-method-registry` here and remove this `babel-runtime` dependency.
    
    [1]: MetaMask/eth-method-registry#29
    Gudahtt committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    6ce1366 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7457b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    04611e4 View commit details
    Browse the repository at this point in the history