Update sinon
and @types/sinon
to latest versions
#352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinon
has been updated from v7 to v9. There have been no breaking changes that affect our usage.The types we were using were far behind though, so updating those has revealed pre-existing mistakes in how we were using
sinon
in a few places.For one of the type errors, I replaced a
window.fetch
mock withnock
, as that seemed like the simplest way to fix the type error.