Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TokenRatesController.fetchAndMapExchangeRates private #3621

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Make TokenRatesController.fetchAndMapExchangeRates private #3621

merged 4 commits into from
Dec 6, 2023

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Dec 5, 2023

Explanation

Revisting this controller after adding PollingController to reduce it's API surface area.

References

Changelog

@metamask/assets-controllers

  • BREAKING: TokenRatesController.fetchAndMapExchangeRates is no longer exposed publicly

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@jiexi jiexi requested a review from a team as a code owner December 5, 2023 23:58
mcmire
mcmire approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

adonesky1
adonesky1 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 4b8533c into main Dec 6, 2023
132 checks passed
@adonesky1 adonesky1 deleted the jl/mmp-2060/token-rates-controller-private-cleanup-2 branch December 6, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update relevant methods to be private in TokenRatesController
3 participants
@jiexi @mcmire @adonesky1