Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shiden chain id #3683

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix: shiden chain id #3683

merged 3 commits into from
Dec 19, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Dec 19, 2023 •
edited
Loading

Explanation

Changed shiden network chain id to the right one 0x150

References

A slack thread about the chain id

For example:

  • Fixes #12345
  • Related to #67890
    -->

Changelog

@metamask/assets-controllers

  • : changed on codefi-v2 file the shiden network chain id to the right one 0x150

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini
add ^ to cockatiel package to install minor versions when released, c…
7cc09d8 
…hange shiden chain ids supported by price api
@tommasini tommasini requested a review from a team as a code owner December 19, 2023 16:07
@tommasini tommasini changed the title fix: cockatiel dependency and shiden chain id fix: shiden chain id Dec 19, 2023
Gudahtt
Gudahtt approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini merged commit f6a1a5c into main Dec 19, 2023
136 checks passed
@tommasini tommasini deleted the fix/shiden-chainid-and-cockatiel-package branch December 19, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommasini @Gudahtt