Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSea supply -> total_supply #3692

Merged
merged 1 commit into from
Dec 20, 2023
Merged

OpenSea supply -> total_supply #3692

merged 1 commit into from
Dec 20, 2023

Conversation

bergeron
Copy link
Contributor

Explanation

OpenSea renamed the field supply, which used to be required, to total_supply. Fixes the error:

undefined is not an object (evaluating 'contract.supply.toString')

A more accurate total_supply was also added to the collection object, which is now preferred to the one on the contract.

References

Changelog

@metamask/assets-controllers

  • FIXED: OpenSea response from supply to total_supply

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@bergeron bergeron requested a review from a team as a code owner December 20, 2023 18:39
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergeron bergeron merged commit 6884767 into main Dec 20, 2023
136 checks passed
@bergeron bergeron deleted the brian/os-supply branch December 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants