refactor(assets-controllers): Simplify TokensController tests
#3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
approved these changes
Jan 8, 2024
The `TokensController` tests have been refactored to use mocks instead of a real `PreferencesController` instance. This should make the tests easier to read, and it will decouple them from the `PreferencesController`. Relates to #3708
Gudahtt
force-pushed
the
refactor-tokens-controller-tests
branch
from
d8f74fd
to
0abbd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
TokensControllertests have been refactored to use mocks instead of a realPreferencesControllerinstance. This should make the tests easier to read, and it will decouple them from thePreferencesController.References
Relates to #3708
Changelog
No changes
Checklist