refactor: Update @metamask/utils and use createDeferredPromise from utils
#3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om utils The `createDeferredPromise` function that had been defined in the `TokenRatesController` has been replaced by the function with the same name from the `@metamask/utils` package. It behaves identically. The `@metamask/utils` package has been updated from `^8.2.0` to `^8.3.0` in all packages because the `createDeferredPromise` function was added in `v8.3.0`.
Gudahtt
force-pushed
the
use-create-deferred-promise-from-utils
branch
from
3f85f7b
to
929fec4
Compare
FrederikBolding
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
createDeferredPromisefunction that had been defined in theTokenRatesControllerhas been replaced by the function with the same name from the@metamask/utilspackage. It behaves identically.The
@metamask/utilspackage has been updated from^8.2.0to^8.3.0in all packages because thecreateDeferredPromisefunction was added inv8.3.0.References
This is a follow-up to #3635. The function was temporarily inlined in that PR, but the plan was always to ship it as part of utils.
This was done now because it helps somewhat with #3763, but it's not a complete blocker.
Changelog
This change entry applies to all packages in the diff for this PR.
Changed
@metamask/utilsto^8.3.0Checklist