Use account snap by default in user operations #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for Bundler helper.
Estimate gas only if not provided by account. Do not throw unless hash function called.
Fix typo.
Create associated unit tests.
…ng-user-operations
Emit transaction-updated events.
Add isUserOperation property to transactions. Add associated unit tests.
Add JSDoc.
Use SnapSmartContractAccount if no SmartContractAccount specified. Add from to AddUserOperationRequest. Update validation. Add associated unit tests.
Set user fee level to custom in transaction if paymaster in use.
matthewwalsh0
added
the
team-confirmations-system
OGPoyraz
approved these changes
Jan 26, 2024
vinistevam
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently the
UserOperationControllerrequires aSmartContractAccountimplementation in order to create user operations withaddUserOperationandaddUserOperationFromTransaction.This PR provides a default implementation via
SnapSmartContractAccountwhich means if no override is provided, all user operations will be created using the current account snap via theKeyringController.In addition, this includes various bug fixes:
userFeeLeveltocustomif using a paymaster.addUserOperationFromTransaction.References
Changelog
@metamask/user-operation-controllerfromproperty toPrepareUserOperationRequest.fromproperty toAddUserOperationRequest.smartContractAccountoptional inAddUserOperationOptions.userFeeLeveltocustomin transaction event if using a paymaster.addUserOperationFromTransaction.Checklist