Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/112.0.0 #3849

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Release/112.0.0 #3849

merged 7 commits into from
Jan 26, 2024

Conversation

BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Jan 25, 2024

Explanation

References

Changelog

@metamask/selected-network-controller

  • CHANGED: NetworkClientId for each domain will be the same as metamask when the feature flag is off

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ requested a review from a team as a code owner January 25, 2024 19:27
@BelfordZ
Copy link
Contributor Author

where is this whitespace coming from, I sure didnt put it there...

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3850 should make the whitespace here valid, so the only thing we need to fix I think are the URLs at the bottom.

packages/selected-network-controller/CHANGELOG.md Outdated Show resolved Hide resolved
mcmire
mcmire previously approved these changes Jan 25, 2024
@adonesky1 adonesky1 merged commit 4e353c0 into main Jan 26, 2024
136 checks passed
@adonesky1 adonesky1 deleted the release/112.0.0 branch January 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants