Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump @metamask/ethjs- packages to latest #3897

Merged
merged 4 commits into from
Feb 8, 2024
Merged

deps: bump @metamask/ethjs- packages to latest #3897

merged 4 commits into from
Feb 8, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 6, 2024 •
edited
Loading

Explanation

  • Bump @metamask/ethjs- packages to latest
  • Removes (peer)dependencies on babel-runtime

References

Blocked by

Related

Changelog

@metamask/assets-controller

  • CHANGED: Bump @metamask/ethjs-provider-http from ^0.2.0 to ^0.3.0

@metamask/controller-utils

  • CHANGED: Bump @metamask/ethjs-unit from ^0.2.1 to ^0.3.0

@metamask/gas-fee-controller

  • CHANGED: Bump @metamask/ethjs-unit from ^0.2.1 to ^0.3.0

@metamask/transaction-controller

  • CHANGED: Bump eth-method-registry from ^3.0.0 to ^4.0.0
  • FIXED: Remove implicit peerDependency on babel-runtime
  • BREAKING: Add peerDependency on @babel/runtime

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security Socket Security
Copy link

socket-security bot commented Feb 6, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/runtime@7.23.9 None +1 277 kB nicolo-ribaudo
npm/@metamask/ethjs-contract@0.4.1 None +13 4.02 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/ethjs-filter@0.3.0 None +2 354 kB lgbot
npm/@metamask/ethjs-format@0.3.0 None +8 1.53 MB lgbot
npm/@metamask/ethjs-provider-http@0.3.0 Transitive: network +3 470 kB lgbot
npm/@metamask/ethjs-query@0.7.1 None +13 2.24 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/ethjs-rpc@0.4.0 None +5 370 kB metamaskbot
npm/@metamask/ethjs-unit@0.3.0 None +6 1.01 MB lgbot
npm/@metamask/ethjs-util@0.3.0 None +4 524 kB lgbot
npm/@metamask/number-to-bn@1.7.1 None +3 410 kB lgbot
npm/eth-method-registry@4.0.0 None +20 5.74 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn

🚮 Removed packages: npm/@metamask/ethjs-rpc@0.3.2

View full report↗︎

This was referenced Feb 7, 2024
Merged
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Feb 7, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat force-pushed the deps-ethjs-remove-babel-runtime branch from d973f91 to f77374f Compare February 7, 2024 21:00
@legobeat legobeat marked this pull request as ready for review February 7, 2024 21:04
@legobeat legobeat requested a review from a team as a code owner February 7, 2024 21:04
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Feb 7, 2024
@legobeat legobeat force-pushed the deps-ethjs-remove-babel-runtime branch 2 times, most recently from aaeeca8 to b2f26dc Compare February 7, 2024 21:53
@legobeat
deps: bump @metamask/ethjs- packages to latest
39cfc7a
@legobeat
deps(transaction-controller): eth-method-registry@^3.0.0->^4.0.0
eaadd27 
- replace peerDependency on babel-runtime with @babel/runtime
@legobeat
chore: remove constraint requiring babel-runtime if eth-method-regist…
f1bdf50 
…ry is present

Starting with eth-method-registry@4.0.0, the package no longer has an
implicit peerDependency on `babel-runtime`.

Instead it now has an explicit peerDependency on `@babel/runtime`.
@legobeat
remove redundant @babel/runtime peerDeps
cfbaf04 
seems to not _actually_ be required for the packages specifying it as a
peerDep here.
@legobeat legobeat force-pushed the deps-ethjs-remove-babel-runtime branch from b2f26dc to cfbaf04 Compare February 8, 2024 08:48
@legobeat legobeat merged commit 065fd91 into MetaMask:main Feb 8, 2024
134 checks passed
@legobeat legobeat deleted the deps-ethjs-remove-babel-runtime branch February 8, 2024 17:28
@legobeat legobeat mentioned this pull request Feb 8, 2024
Closed
3 tasks
mcmire
mcmire reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here, just letting you know I've seen this and thanks for taking care of this!

constraints.pro
@@ -396,10 +396,3 @@ gen_enforced_field(WorkspaceCwd, 'publishConfig.registry', 'https://registry.npm
% whatsoever.
gen_enforced_field(WorkspaceCwd, 'publishConfig', null) :-
workspace_field(WorkspaceCwd, 'private', true).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@legobeat legobeat mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

@Mrtenz Mrtenz Mrtenz approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mcmire @Mrtenz