Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: import BN directly from bn.js instead of through ethereumjs-util #3910

Closed
wants to merge 1 commit into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 8, 2024

Explanation

Legacy ethereumjs-util is used primarily for two things: its re-exported bn.js instance and a handful of bytes/hex/string utility functions.

This removes the first category by importing BN directly from bn.js instead of via ethereumjs-util.

The version is the same. No user-facing changes.

References

Changelog

@metamask/gas-fee-controller

  • REMOVED: Remove unused dependency ethereumjs-util

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

socket-security bot commented Feb 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/bn.js@5.1.5 None +1 3.57 MB types

🚮 Removed packages: npm/@types/bn.js@5.1.1

View full report↗︎

@legobeat
Copy link
Contributor Author

Superseded by #3943

@legobeat legobeat closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant