Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: price api cache control #3939

Merged
merged 5 commits into from
Feb 23, 2024
Merged

fix: price api cache control #3939

merged 5 commits into from
Feb 23, 2024

Conversation

bergeron
Copy link
Contributor

Explanation

Sets Cache-Control: no-cache on price API requests.

See: https://consensys.slack.com/archives/C065W3877E3/p1708468886411439?thread_ts=1708466257.782319&cid=C065W3877E3

References

Changelog

@metamask/assets-controllers

  • CHANGED: HTTP requests to the price API now use the no-cache directive.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@bergeron bergeron requested a review from a team as a code owner February 21, 2024 02:01
mcmire
mcmire approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense to me.

@bergeron bergeron merged commit e9fc9f1 into main Feb 23, 2024
138 checks passed
@bergeron bergeron deleted the brian/cache-control branch February 23, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@blurpesec blurpesec Awaiting requested review from blurpesec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergeron @mcmire