fix: fix detecting NFTs after closing browser

[sahar-fehri]

Explanation

This PR goes together with this extension PR MetaMask/metamask-extension#24162

We want to reduce third party calls for nft detection when a user has closed the MM popup/window.
To do that we are leveraging stopNetworkRequests and triggerNetworkrequests functions inside extension to either stop() or start() the nft detection.
While doing this fixed the following scenario:

1- User imports MM wallet
2- User enables nft detection toggle
3- User closes MM tab or popup
4- We are no longuer making calls to third party because we called stop() function on nftDetectionController.

It does not fix this scenario:
1- User imports MM wallet
2- User enabled nft detection toggle
3- User closes chrome all together
4- User reopens chrome without opening MM, and we notice that it is making calls in the background to third party even though MM is not open.

This behavior was happening because of a couple of reasons; the property disabled being set to true in defaultConfig

    this.defaultConfig = {
      interval: DEFAULT_INTERVAL,
      chainId: initialChainId,
      selectedAddress: '',
      disabled: true,
    };

made the check on this line pass

core/packages/assets-controllers/src/NftDetectionController.ts

Line 480 in 1551844

!useNftDetection !== disabled

and triggered the start() function (because the useNftDetection is true).

I fixed this by having extension pass the disabled in the contructor rather than having the true value hardcoded in the controller.

I have also refactored the onPreferencesStateChange to have it make this check

      if(selectedAddress !== previouslySelectedAddress){
          this.configure({ selectedAddress });
      }

Separately.
When the user first opens the selectedAddress is '' because its also set in default config which, because of the OR statement triggered the code to also go into the start()

References

Changelog

@metamask/assets-controllers

• ADDED: Added disabled inside contructor of nftDetectionController
• CHANGED: Pass new disabled value instead of true in the default config
• CHANGED: Made the check for the selected address separate from the check of useNftDetection value

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate